feat: allow external integrity/size source #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
May 16, 2022
nlf
force-pushed
the
nlf/allow-external-integrity
branch
from
f890f7b
to
46ab18a
Compare
nlf
force-pushed
the
nlf/allow-external-integrity
branch
from
46ab18a
to
421773f
Compare
wraithgar
approved these changes
May 17, 2022
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this feature allows us to pass our own event emitter that emits both the 'size' and 'integrity' events and avoid the creation of an internal integrity stream.
the immediate use case for this is in make-fetch-happen, where we already have an integrity stream in place. by passing the events in this way, we avoid calculating hashes multiple times thereby improving performance