Ouput registry information before prompting user for login information #2075
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wicked7000
changed the title
Wicked7000
force-pushed
the
feature-login-registry
branch
from
4710309 to
5f6626e
Compare
darcyclarke
added
Release 7.x
ruyadorno
reviewed
Oct 29, 2020
There was a problem hiding this comment.
hi @Wicked7000 thanks for the awesome contribution!
Not a blocker to merge it since I believe we can address it later if the team has strong feelings about it but I believe this message would be better implemented as npmlog.notice for a few reasons:
- visual printed output is a little bit more highlighted
- that allow us to keep handling
outputonly inlib/adduser.js - provide users a way to opt-out of the message by tuning diff loglevels
darcyclarke
removed
the
release: next
Wicked7000
force-pushed
the
feature-login-registry
branch
from
5f6626e to
009a90b
Compare
ruyadorno
reviewed
Nov 3, 2020
ruyadorno
force-pushed
the
feature-login-registry
branch
from
3bcc188 to
cd509e9
Compare
ruyadorno
approved these changes
Nov 6, 2020
darcyclarke
added
release: next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change outputs the registry before prompting the user for the login information.
Related to/Resolves: #2071