Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set NODE_ENV=production if 'dev' is on the omit list #2331

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Set NODE_ENV=production if 'dev' is on the omit list #2331

merged 2 commits into from
Dec 11, 2020

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 11, 2020

Fix: #2021

References

@isaacs isaacs requested a review from a team as a code owner December 11, 2020 19:01
@isaacs isaacs added release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release labels Dec 11, 2020
@isaacs isaacs changed the base branch from latest to release/v7.1.2 December 11, 2020 19:37
@isaacs isaacs force-pushed the isaacs/set-node-env-production branch from 197d9fe to 3154491 Compare December 11, 2020 19:37
@isaacs isaacs merged commit 3154491 into release/v7.1.2 Dec 11, 2020
@isaacs isaacs mentioned this pull request Dec 11, 2020
Merged
This was referenced Dec 11, 2020
Closed
Closed
@nlf nlf deleted the isaacs/set-node-env-production branch March 28, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm@7 does not set NODE_ENV=production when --production option is used
2 participants
@isaacs @ruyadorno