-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update publish docs #2778
Closed
Closed
update publish docs #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Feb 25, 2021
ethomson
approved these changes
Feb 25, 2021
wraithgar
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
labels
Feb 25, 2021
We also removed the "none" script because we handle a missing script just fine. There is no need to put an empty one in PR-URL: #2759 Credit: @wraithgar Close: #2759 Reviewed-by: @nlf
To make the headings consistent. PR-URL: #2760 Credit: @MrBrain295 Close: #2760 Reviewed-by: @wraithgar
The documentation in this repository is added to the overall npm documentation at https://docs.npmjs.com/, which includes both the documentation for the public registry and the CLI. The documentation site itself also has a navigational hierarchy; since the content is included from the CLI, we also want to ensure that the navigation for that content lives in this repository. This means that this repository is the source of truth for all of the CLI documentation, and we do not need to update two places when we add, edit, or remove CLI documentation. It all lives here. This also teaches the documentation rendering script to identify when the navigation configuration (nav.yml) is missing new pages that were recently added or retains old pages that have recently been deleted. PR-URL: #2775 Credit: @ethomson Close: #2775 Reviewed-by: @wraithgar
PR-URL: #2778 Credit: @christoflemke Close: #2778 Reviewed-by: @wraithgar, @ethomson
wraithgar
force-pushed
the
christoflemke/update-publish-docs
branch
from
February 25, 2021 17:55
4e22803
to
238e474
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unpublish cooldown period to 28 days.
References
Related to https://github.com/github/npm/issues/1737
And #2778