Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): accept explicit production=false #2951

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

wraithgar
Copy link
Member

This allows for overriding the implicit omit value based on if
NODE_ENV=production

References

Fixes #2936

Screen Shot 2021-03-24 at 1 39 32 PM

@wraithgar wraithgar requested a review from a team as a code owner March 24, 2021 20:40
@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release labels Mar 24, 2021
@ruyadorno ruyadorno added the release: next These items should be addressed in the next release label Mar 24, 2021
This allows for overriding the implicit omit value based on if
NODE_ENV=production

PR-URL: #2951
Credit: @wraithgar
Close: #2951
Reviewed-by: @ruyadorno
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants