Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <Documentation Missing on Local Paths and Peer Dependencies> #3736

Closed
1 task done
dillonledoux opened this issue Sep 10, 2021 · 1 comment
Closed
1 task done
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@dillonledoux
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If a package is being referenced using a local path designated in the package.json file, any peer dependencies of the referenced package will not be downloaded and installed. The local package must first be packed for it to download the packages.

Expected Behavior

The behavior of a package needing to be packed before peer dependencies are installed should be in the documentation in this section or npm should be modified to install peer dependencies from packages using local paths.

Steps To Reproduce

  1. Using npm 7 and an angular package with a peer dependency
  2. Run ng build
  3. In another app, reference the above package using a local path in the local dist directory
  4. Build the app using ng build
  5. You should notice the peer dependency can't be resolved

Environment

  • OS: Windows 10, build 1909
  • Node: 16.9.0
  • npm: 7.19.1
@dillonledoux dillonledoux added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Sep 10, 2021
@wraithgar
Copy link
Member

This is working as intended. Linked deps do not have their dependencies installed, you have to install them inside that linked dep as a separate step.

Docs update PR explaining that has been created #4575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

2 participants