Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): command completion with single match #4023

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 9, 2021

During a refactoring of the tests a bug was found in the install command
completion that would return nothing if there was a valid match, this
fixes that bug and also makes the tests actually test things.

@wraithgar wraithgar requested a review from a team as a code owner November 9, 2021 18:21
@wraithgar wraithgar changed the title gar/install tests fix(install): command completion with single match Nov 9, 2021
@ljharb
Copy link
Contributor

ljharb commented Nov 9, 2021

Related to #4020?

@wraithgar
Copy link
Member Author

Nope that'd be a different issue, each command has its own completions function

@wraithgar wraithgar force-pushed the gar/install-tests branch 5 times, most recently from 3ecc7bd to d49addc Compare November 10, 2021 15:39
@wraithgar wraithgar added Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes labels Nov 10, 2021
During a refactoring of the tests a bug was found in the install command
completion that would return nothing if there was a valid match, this
fixes that bug and also makes the tests actually test things.

PR-URL: #4023
Credit: @wraithgar
Close: #4023
Reviewed-by: @lukekarrys
@wraithgar wraithgar merged commit b789491 into release-next Nov 10, 2021
@wraithgar wraithgar deleted the gar/install-tests branch November 10, 2021 22:40
@fritzy fritzy mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants