Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs) override docs #4092

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore(docs) override docs #4092

merged 1 commit into from
Dec 8, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Nov 24, 2021

Adding a first pass at documentation for overrides. This should not land until after the actual feature lands in arborist, and the dep is updated here in the cli. Marking this pull request as a draft until then.

Arborist has landed the feature, and the PR is open for the dep update #4116 so this is now unblocked

References

Depends on npm/arborist#354

@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 8.x work is associated with a specific npm 8 release labels Nov 30, 2021
@nlf nlf marked this pull request as ready for review December 2, 2021 22:46
@nlf nlf requested a review from a team as a code owner December 2, 2021 22:46
@nlf
Copy link
Contributor Author

nlf commented Dec 2, 2021

this can land after #4116

Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specifics are right, we can iterate on the rest of the copy if it becomes necessary.

PR-URL: #4092
Credit: @nlf
Close: #4092
Reviewed-by: @wraithgar
@nlf nlf merged commit db1885d into release-next Dec 8, 2021
@nlf nlf deleted the nlf/override-docs branch December 8, 2021 23:27
@nlf nlf mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants