Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display publishConfig during config list #4146

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Dec 9, 2021

Closes: npm/statusboard#417

If the file at $NPM_CONFIG_PREFIX/package.json contains a
publishConfig, the key/value pairs will be printed along with the rest
of the output from npm config ls.

@lukekarrys lukekarrys requested a review from a team as a code owner December 9, 2021 00:13
@npm-robot
Copy link
Contributor

npm-robot commented Dec 9, 2021

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 52.508 ±0.30 37.068 ±0.34 28.826 ±7.28 25.692 ±0.97 3.698 ±0.04 3.744 ±0.02 2.981 ±0.09 15.889 ±0.14 3.027 ±0.04 3.859 ±0.01
#4146 52.706 ±0.49 37.432 ±0.78 28.964 ±7.62 27.012 ±0.12 3.667 ±0.02 3.702 ±0.01 3.006 ±0.03 15.959 ±0.02 3.089 ±0.12 4.194 ±0.10
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 39.634 ±1.62 28.291 ±0.13 16.707 ±0.23 18.119 ±0.62 3.337 ±0.06 3.431 ±0.08 3.141 ±0.04 11.619 ±0.18 2.877 ±0.04 3.601 ±0.07
#4146 40.303 ±0.97 29.541 ±0.12 17.734 ±0.17 18.708 ±0.08 3.540 ±0.08 3.482 ±0.02 3.149 ±0.02 12.103 ±0.10 3.004 ±0.01 3.659 ±0.03

Closes: npm/statusboard#417

If the file at `$NPM_CONFIG_PREFIX/package.json` contains a
`publishConfig`, the key/value pairs will be printed along with the rest
of the output from `npm config ls`.

PR-URL: #4146
Credit: @lukekarrys
Close: #4146
Reviewed-by: @nlf
@nlf nlf force-pushed the lk/config-ls-publishconfig branch from 061e5f2 to 71777be Compare December 9, 2021 18:09
@nlf nlf merged commit 71777be into release-next Dec 9, 2021
@nlf nlf deleted the lk/config-ls-publishconfig branch December 9, 2021 18:09
@nlf nlf mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants