Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper workspace repo urls in package.json #4476

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 26, 2022

v5 was published 2 days ago but still points to the archived repo.

@ljharb ljharb requested a review from a team as a code owner February 26, 2022 19:32
@ljharb ljharb added the ws:arborist Related to the arborist workspace label Feb 26, 2022
@lukekarrys
Copy link
Contributor

Good catch! It looks like we should fix this for all the workspaces:

// npm pkg get repository -ws --include-workspace-root
{
  "npm": {
    "type": "git",
    "url": "https://github.com/npm/cli"
  },
  "docs": {
    "type": "git",
    "url": "https://github.com/npm/cli"
  },
  "@npmcli/arborist": {
    "type": "git",
    "url": "https://github.com/npm/arborist"
  },
  "libnpmaccess": {
    "type": "git",
    "url": "https://github.com/npm/libnpmaccess.git"
  },
  "libnpmdiff": "https://github.com/npm/libnpmdiff",
  "libnpmexec": "https://github.com/npm/libnpmexec",
  "libnpmfund": "https://github.com/npm/libnpmfund",
  "libnpmhook": "https://github.com/npm/libnpmhook",
  "libnpmorg": {
    "type": "git",
    "url": "https://github.com/npm/libnpmorg.git"
  },
  "libnpmpack": {
    "type": "git",
    "url": "https://github.com/npm/libnpmpack.git"
  },
  "libnpmpublish": {
    "type": "git",
    "url": "https://github.com/npm/cli.git"
  },
  "libnpmsearch": {
    "type": "git",
    "url": "https://github.com/npm/libnpmsearch.git"
  },
  "libnpmteam": {
    "type": "git",
    "url": "https://github.com/npm/libnpmteam.git"
  },
  "libnpmversion": {
    "type": "git",
    "url": "git+https://github.com/npm/libnpmversion"
  }
}

@ljharb
Copy link
Contributor Author

ljharb commented Feb 26, 2022

If there's a single npm command that could set those, including the proper directory field, I'd be happy to update this PR with that result :-)

Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now, and will serve as a test that it doesn't get changed when npm/template-oss#66 gets implemented.

@wraithgar wraithgar changed the base branch from latest to release-next February 28, 2022 22:51
@ljharb ljharb added ws:libnpmaccess Related to the libnpmaccess workspace. ws:libnpmdiff Related to the libnpmdiff workspace ws:libnpmexec Related to the libnpmexec workspace ws:libnpmhook Related to the libnpmhook workspace ws:libnpmorg Related to the libnpmorg workspace. ws:libnpmpack Related to the libnpmpack workspace ws:libnpmpublish Related to the libnpmpublish workspace. ws:libnpmsearch Related to the libnpmsearch workspace ws:libnpmteam Related to the libnpmteam workspace ws:libnpmversion Related to the libnpmversion workspace labels Mar 1, 2022
@ljharb
Copy link
Contributor Author

ljharb commented Mar 1, 2022

Went ahead and manually updated it.

Note: you're missing a label for libnpmfund :-)

@wraithgar wraithgar added the ws:libnpmfund Related to the libnpmfund workspace label Mar 1, 2022
@wraithgar wraithgar changed the title [arborist] fix repo URL fix: set proper workspace repo urls in package.json Mar 1, 2022
@wraithgar
Copy link
Member

Waiting on https://github.com/npm/cli/pull/4487 before merging this so that release-please can do its thing after we merge this.

@wraithgar wraithgar merged commit 0cfc155 into npm:release-next Mar 2, 2022
@ljharb ljharb deleted the patch-1 branch March 2, 2022 21:07
This was referenced Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws:arborist Related to the arborist workspace ws:libnpmaccess Related to the libnpmaccess workspace. ws:libnpmdiff Related to the libnpmdiff workspace ws:libnpmexec Related to the libnpmexec workspace ws:libnpmfund Related to the libnpmfund workspace ws:libnpmhook Related to the libnpmhook workspace ws:libnpmorg Related to the libnpmorg workspace. ws:libnpmpack Related to the libnpmpack workspace ws:libnpmpublish Related to the libnpmpublish workspace. ws:libnpmsearch Related to the libnpmsearch workspace ws:libnpmteam Related to the libnpmteam workspace ws:libnpmversion Related to the libnpmversion workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants