Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide banner for exec and explore #7421

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix: hide banner for exec and explore #7421

merged 3 commits into from
Apr 25, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 25, 2024 •
edited by wraithgar
Loading

Fixes #7419

@lukekarrys lukekarrys requested a review from a team as a code owner April 25, 2024 20:49
@lukekarrys lukekarrys force-pushed the lk/hide-exec-banner branch from cd1378c to 18bfc47 Compare April 25, 2024 20:50
wraithgar
wraithgar approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass :shipit:

@lukekarrys lukekarrys force-pushed the lk/hide-exec-banner branch from 1b18ff5 to 58fd1cb Compare April 25, 2024 21:22
@lukekarrys lukekarrys force-pushed the lk/hide-exec-banner branch from b1a2e60 to b284b23 Compare April 25, 2024 21:26
@lukekarrys lukekarrys mentioned this pull request Apr 25, 2024
Closed
2 tasks
wraithgar
wraithgar approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can make deref only needed once in a future improvement.

@lukekarrys lukekarrys merged commit 71cbd91 into latest Apr 25, 2024
20 checks passed
@lukekarrys lukekarrys deleted the lk/hide-exec-banner branch April 25, 2024 22:19
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Merged
@wraithgar wraithgar mentioned this pull request Apr 27, 2024
Closed
@milaninfy milaninfy mentioned this pull request Apr 29, 2024
Closed
2 tasks
@dominykas dominykas mentioned this pull request Apr 29, 2024
Closed
2 tasks
@npm-cli-bot npm-cli-bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NPM 10.6.0 outputs new lines when running npx
2 participants
@lukekarrys @wraithgar