Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] regression? "license" key in lockfile is never populated #7648

Closed
chrisdlangton opened this issue Jul 15, 2024 · 6 comments
Closed

[BUG] regression? "license" key in lockfile is never populated #7648

chrisdlangton opened this issue Jul 15, 2024 · 6 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps

Comments

@chrisdlangton
Copy link

chrisdlangton commented Jul 15, 2024

Regression? Seems to be fixed in v10.8.2 according to issue 5532 comment by @lukekarrys

But is occurring today:

nvm use --lts
node --version
// 10.8.2
npm --version
// v20.15.1

I narrowed it down to the difference between:

npm install works as expected

npm update strips licenses as described in #5532

@chrisdlangton chrisdlangton added Bug thing that needs fixing Needs Triage needs review for next steps labels Jul 15, 2024
@chrisdlangton chrisdlangton changed the title [BUG] <title> [BUG] regression? "license" key in lockfile is never populated Jul 15, 2024
@kchindam-infy
Copy link

HI @chrisdlangton Could you list exact cmd you ran that led to license being stripped from lockfile?
If possible could you share a minimal example of your package.json and pakcage.lock.json before and after npm update?

@chrisdlangton
Copy link
Author

HI @chrisdlangton Could you list exact cmd you ran that led to license being stripped from lockfile? If possible could you share a minimal example of your package.json and pakcage.lock.json before and after npm update?

I have, and the results of the update vs install command is obvious if you run it

@wraithgar
Copy link
Member

Please use the issue template when making new issues. We get a LOT of issues opened and unless there is a very clearly defined reproduction case we simply do not have the time to try to find out how to reproduce them with limited info. Thanks.

@HonkingGoose

This comment has been minimized.

@chrisdlangton
Copy link
Author

chrisdlangton commented Aug 10, 2024

@HonkingGoose not a duplicate
The linked issue is closed and related to install

This is new, distinctly related to update not install, and the lock file not package.json, as described, very clearly..

And clearly reproductive too, so your comment is ingenuous

Besides, the install issue couldn't have been a duplicate if you had read the report, so it's clear you also didn't read the reproduction steps.

So, I created the identical content of this issue in the template, just in case layout was the cause of quick/sloppy triage - sorry for being concise and missing this layout requirement, I can be a bit too efficient sometimes and only realise others have trouble with it afterwards

@HonkingGoose
Copy link

I apologize for getting it wrong! I'm hiding my comment as "off-topic". 😉

I'll let the maintainers figure things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps
Projects
None yet
Development

No branches or pull requests

4 participants