From 2c5194260cb861c0c19488f6c6f059e8235fc98a Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Sun, 10 Apr 2022 11:03:36 -0700 Subject: [PATCH 1/2] feat(config): add more npm/node information to config ls --- lib/commands/config.js | 3 +++ tap-snapshots/test/lib/commands/config.js.test.cjs | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/lib/commands/config.js b/lib/commands/config.js index 690a69a3233e4..24bab5fe6c9e6 100644 --- a/lib/commands/config.js +++ b/lib/commands/config.js @@ -266,6 +266,9 @@ ${defData} if (!long) { msg.push( `; node bin location = ${process.execPath}`, + `; node version = ${process.version}`, + `; npm bin location = ${dirname(dirname(__dirname))}`, + `; npm version = ${this.npm.version}`, `; cwd = ${process.cwd()}`, `; HOME = ${process.env.HOME}`, '; Run `npm config ls -l` to show all defaults.' diff --git a/tap-snapshots/test/lib/commands/config.js.test.cjs b/tap-snapshots/test/lib/commands/config.js.test.cjs index f98e74c066269..21add30da7be0 100644 --- a/tap-snapshots/test/lib/commands/config.js.test.cjs +++ b/tap-snapshots/test/lib/commands/config.js.test.cjs @@ -342,6 +342,9 @@ prefix = "{LOCALPREFIX}" userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} +; node version = {NODE-VERSION} +; npm bin location = {NPMDIR} +; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME} ; Run \`npm config ls -l\` to show all defaults. @@ -355,6 +358,9 @@ prefix = "{LOCALPREFIX}" userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} +; node version = {NODE-VERSION} +; npm bin location = {NPMDIR} +; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME} ; Run \`npm config ls -l\` to show all defaults. @@ -383,6 +389,9 @@ prefix = "{LOCALPREFIX}" userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} +; node version = {NODE-VERSION} +; npm bin location = {NPMDIR} +; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME} ; Run \`npm config ls -l\` to show all defaults. From f1596d0e96f144205cc9fbb42b82d7e64b847758 Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Mon, 11 Apr 2022 11:19:00 -0700 Subject: [PATCH 2/2] fixup! feat(config): add more npm/node information to config ls --- lib/commands/config.js | 2 +- tap-snapshots/test/lib/commands/config.js.test.cjs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/commands/config.js b/lib/commands/config.js index 24bab5fe6c9e6..0432abac391f3 100644 --- a/lib/commands/config.js +++ b/lib/commands/config.js @@ -267,7 +267,7 @@ ${defData} msg.push( `; node bin location = ${process.execPath}`, `; node version = ${process.version}`, - `; npm bin location = ${dirname(dirname(__dirname))}`, + `; npm local prefix = ${this.npm.localPrefix}`, `; npm version = ${this.npm.version}`, `; cwd = ${process.cwd()}`, `; HOME = ${process.env.HOME}`, diff --git a/tap-snapshots/test/lib/commands/config.js.test.cjs b/tap-snapshots/test/lib/commands/config.js.test.cjs index 21add30da7be0..56ef71f3efd3c 100644 --- a/tap-snapshots/test/lib/commands/config.js.test.cjs +++ b/tap-snapshots/test/lib/commands/config.js.test.cjs @@ -343,7 +343,7 @@ userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} ; node version = {NODE-VERSION} -; npm bin location = {NPMDIR} +; npm local prefix = {LOCALPREFIX} ; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME} @@ -359,7 +359,7 @@ userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} ; node version = {NODE-VERSION} -; npm bin location = {NPMDIR} +; npm local prefix = {LOCALPREFIX} ; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME} @@ -390,7 +390,7 @@ userconfig = "{HOME}/.npmrc" ; node bin location = {EXECPATH} ; node version = {NODE-VERSION} -; npm bin location = {NPMDIR} +; npm local prefix = {LOCALPREFIX} ; npm version = {NPM-VERSION} ; cwd = {NPMDIR} ; HOME = {HOME}