fix: dont omit license from stored manifests #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the effect of adding licenses back into the lockfiles. Based on code in shrinkwrap.js and inventory.js, it appears that lockfiles are supposed to store the license. It's likely that in practice this behavior has not been consistent due to fetching of minifed manifests and packuments. I also attempted to remove the license code from shrinkwrap but that caused many more tests to break. Plus I believe this is the intended behavior, to have licenses in lockfiles based on bug reports like #7384
ljharb
approved these changes
May 6, 2024
wraithgar
approved these changes
May 6, 2024
Merged
1 task
techknowlogick
pushed a commit
to go-gitea/gitea
that referenced
this pull request
Jul 11, 2024
Result of `make update-js`. Tested all dependencies. Lockfile diff is because of npm/cli#7475.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the effect of adding licenses back into the lockfiles.
Based on code in shrinkwrap.js and inventory.js, it appears that
lockfiles are supposed to store the license. It's likely that in
practice this behavior has not been consistent due to fetching
of minifed manifests and packuments.
I also attempted to remove the license code from shrinkwrap but
that caused many more tests to break. Plus I believe this is the
intended behavior, to have licenses in lockfiles based on bug
reports like #7384