Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Object.assign fallback #25

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Remove Object.assign fallback #25

merged 3 commits into from
Mar 7, 2018
+6 −4

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Jun 21, 2017 •
edited
Loading

Node 4+, like .travis.yml is configured to test.

This is useful to keep the browserified bundle size down by excluding a package/method that is no longer used anywhere (util/_extend)

80KB -> 58KB (28%)

standard@10.0 also includes this suggestion:

git-host.js:3:31: 'util._extend' was deprecated since v6. Use 'Object.assign()' instead. (node/no-deprecated-api)

@fregante fregante mentioned this pull request Jun 21, 2017
Closed
zkat
zkat approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- We explicitly haven't supported anything under node@4 for a while. Thanks for the patch!

@zkat zkat merged commit 627ab55 into npm:master Mar 7, 2018
@fregante fregante deleted the patch-1 branch March 8, 2018 03:14
@loganfsmyth
Copy link

I just want to throw out that I wish this had been done as a new major version. The 2.x release of this package was out during the lifetime of 0.12, so it's not unreasonable to assume that people were expecting only features compatible with that would be in use. I'm all for dropping support for old versions, but it still seems like a semver-breaking change, even if the older environments are out of LTS.

We can no longer build Babel 6 because a sub-sub-dependency uses this package, and Babel 7 is the first release that will be dropping support for 0.10 and 0.12.

iarna added a commit that referenced this pull request Jun 25, 2018
@iarna
Revert "fix(compat): remove Object.assign fallback (#25)"
5b580a8 
This reverts commit 627ab55.
iarna added a commit that referenced this pull request Jun 25, 2018
@iarna
Revert "fix(compat): remove Object.assign fallback (#25)"
0b7f9dc 
This reverts commit 627ab55.

Fixes: #31
iarna added a commit that referenced this pull request Jun 25, 2018
@iarna
Revert "fix(compat): remove Object.assign fallback (#25)"
54634c9 
This reverts commit 627ab55.

Fixes: #31
iarna added a commit that referenced this pull request Jul 6, 2018
@iarna
fix(Revert): "compat: remove Object.assign fallback (#25)"
cce5a62 
This reverts commit 627ab55.
@fregante fregante mentioned this pull request Sep 19, 2018
Closed
isaacs added a commit that referenced this pull request Aug 4, 2019
@isaacs
inline util._extend, rather than requiring util
a5a91ac 
Related:
- #25
- #40

This removes the require('util') fallback for Object.assign, without
dropping support for node v4 (which will happen on the next major,
likely along with 6), but gets bundle sizes down in the meantime.
@JACKEYBANKZ JACKEYBANKZ mentioned this pull request Oct 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fregante @loganfsmyth @zkat @bfred-it