Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default verbatim to undefined #135

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: default verbatim to undefined #135

merged 1 commit into from
Mar 29, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Mar 29, 2022

defaulting verbatim to undefined allows both the node flag --dns-result-order and dns.setDefaultResultOrder() to be respected

closes #134

@nlf nlf requested a review from a team as a code owner March 29, 2022 15:46
@nlf nlf merged commit be0cf6a into main Mar 29, 2022
@nlf nlf deleted the nlf/unset-verbatim-default branch March 29, 2022 16:39
@github-actions github-actions bot mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Verbatim defaulting to true changes behavior in older versions of Node.js
2 participants
@nlf @wraithgar