Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

variable leak: tabWidth #180

Closed
aredridel opened this issue May 20, 2016 · 7 comments
Closed

variable leak: tabWidth #180

aredridel opened this issue May 20, 2016 · 7 comments

Comments

@aredridel
Copy link
Contributor

When integrating marky 7, I ran into our test suite flagging this leaking into global scope:

The following leaks were detected:tabWidth

@aredridel
Copy link
Contributor Author

Failing test case in #181

@revin
Copy link
Collaborator

revin commented May 20, 2016

oops, that's my fault: https://github.com/revin/markdown-it-expand-tabs/blob/master/index.js#L5-L9 ; I'll fix it ASAP

@revin
Copy link
Collaborator

revin commented May 20, 2016

(Where's the 'dependency author is a n00b' label?)

@aredridel
Copy link
Contributor Author

(Nowhere 'cause we all do this. It's one of the sharp corners of JS)

@revin
Copy link
Collaborator

revin commented May 20, 2016

ok I pushed markdown-it-expand-tabs@1.0.10; we semver it in as ^1.0.7 so it should work OOTB now, no?

@revin
Copy link
Collaborator

revin commented May 24, 2016

Got a new PR: #186.

@revin
Copy link
Collaborator

revin commented May 28, 2016

Fixed by markdown-it-expand-tabs@1.0.10, test implemented here in #186

@revin revin closed this as completed May 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants