-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert to typescript and esm #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes suggested.
And yes, definitely remove the read.d.ts
if this is being written in TS, it will be extraneous and just serve to confuse things. Better to let TS find the appropriate dialect-specific types in dist.
14b6e6e
to
8b4d28c
Compare
Made all the changes suggested. I was not set on a default export, and I think TypeScript+ESM is a good push for us to end the pattern |
Those node 14 tests are never going to pass with tap 18, probably best to remove from the matrix. |
yes node 14 is definitely getting dropped as part of this PR |
ae6580e
to
bec6462
Compare
If we're bumping engines let's bump engines npm view npm engines
{ node: '^18.17.0 || >=20.5.0' } $ npm query '#read' |json -a _id from
read@2.1.0 [
"node_modules/init-package-json",
"node_modules/promzard",
"workspaces/libnpmexec",
""
] |
2702dc8
to
d604cc1
Compare
d3d2501
to
1e61bc0
Compare
1e61bc0
to
bc4337e
Compare
4ba826a
to
51e6b4d
Compare
51e6b4d
to
dbdeaf2
Compare
This is now using @wraithgar It also removes the engines update entirely as I dropped it back to |
BREAKING CHANGE: `read` is now written in TypeScript and types are now shipped as part of this package. BREAKING CHANGE: `read` now only exports a named export `{ read }` and does not have a default export.
dbdeaf2
to
c53ac8d
Compare
Bumped out of date devDeps and adding |
BREAKING CHANGE:
read
is now written in TypeScript and types are nowshipped as part of this package.
BREAKING CHANGE:
read
now only exports a named export{ read }
and does not have a default export.
TODO:
template-oss-check
passesallowImportingTsExtensions
)