Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add arguments back to the logged banner #102

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Aug 8, 2022

when we implemented the temp file for scripts, a subtle thing that we lost was the banner logging both the script itself as well as the arguments it received. this pull request restores that behavior, which i think is more clear and helpful for our users

current behavior (in this repo):

❯ npm test -- --coverage-report=html

> @npmcli/run-script@4.2.0 test
> tap

new behavior:

❯ npm test -- --coverage-report=html

> @npmcli/run-script@4.2.0 test
> tap --coverage-report=html

@nlf nlf requested a review from a team as a code owner August 8, 2022 17:17
@nlf nlf merged commit 8e08311 into main Aug 9, 2022
@nlf nlf deleted the nlf/restore-banner-args branch August 9, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants