Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(config): map legacy options to --location & --strategy #458

Closed
6 tasks done
Tracked by #443
darcyclarke opened this issue Mar 18, 2022 · 1 comment
Closed
6 tasks done
Tracked by #443
Assignees
Labels
Milestone

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Mar 18, 2022

  • remove --local config
  • remove --global-style
  • remove --legacy-bundling
  • add --strategy config with four reify mode options:
    • hoisted (current default mode)
    • nested (formerly --legacy-bundling mode, where deps are installed in place - no hoisting)
    • shallow (formerly --global-style mode, where only direct deps are installed at top-level node_modules)
    • linked (future isolated mode)
  • --global should now set --location=global & --strategy=nested when true
  • all relevant code paths should use --location & --strategy in place of their legacy counterparts
@darcyclarke darcyclarke mentioned this issue Mar 18, 2022
32 tasks
@darcyclarke darcyclarke changed the title Map to BREAKING CHANGE(config): map location values to bare variants Mar 23, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): map location values to bare variants BREAKING CHANGE(config): map legacy flags to --location config Mar 23, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): map legacy flags to --location config BREAKING CHANGE(config): map legacy flags to --location & --strategy configs Mar 23, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): map legacy flags to --location & --strategy configs BREAKING CHANGE(config): map legacy config to --location & --strategy Mar 23, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(config): map legacy config to --location & --strategy BREAKING CHANGE(config): map legacy options to --location & --strategy Mar 23, 2022
@lukekarrys lukekarrys added this to the v9.0.0 milestone Sep 2, 2022
@fritzy fritzy self-assigned this Oct 5, 2022
@fritzy
Copy link

fritzy commented Oct 18, 2022

--strategy is actually --install-strategy to avoid confusion with auth configuration.

--global was already setting --location in the CLI. While --global does set --install-strategy=shallow in arborist itself, it does not set --location in arborist directly, but within the npm CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants