-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(bin): command should not return non-existent paths #479
Comments
This is working as intended, feature changes need to go through the rfc process. Added |
Note that it would definitely be a breaking change for any shell prompts that are unconditionally adding |
Based on several Open RFC discussions, we believe that not supporting Actions
|
Is there an existing issue for this?
This issue exists in the latest npm version
Current Behavior
Run
npm bin
in a directory that doesn't have apackage.json
and isn't a child of a directory that does. Currentlynpm bin
returns a string with${pwd}/node_modules/.bin
even if it doesn't exist.Expected Behavior
I'm not sure what I expected, but I didn't expect
npm bin
to present a path to a non-existent directory.Barring a backwards breaking change to the tool, an option like
--strict
would be a reasonable way to add the behavior. It's fairly trivial to test the path that gets returned, but it generates a bit more work than throwing a flag behindnpm bin
Steps To Reproduce
Environment
The text was updated successfully, but these errors were encountered: