Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): remove deprecation warning for auth-type #512

Closed
1 task done
Tracked by #489
darcyclarke opened this issue May 16, 2022 · 1 comment
Closed
1 task done
Tracked by #489

feat(config): remove deprecation warning for auth-type #512

darcyclarke opened this issue May 16, 2022 · 1 comment
Assignees
Labels

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented May 16, 2022

Summary

Previously we added a deprecation warning for auth-type as it was a config queued to be removed but we've recently shipped webauthn support under this config meaning it likely needs to persist for some time beyond the next major

Exit Criteria

  • consider changing the deprecation warning to just display when sso, saml or oauth values are passed to auth-type (this provides us with a path forward to consolidating these values into a singular legacy option)
@darcyclarke darcyclarke mentioned this issue May 16, 2022
13 tasks
@darcyclarke darcyclarke changed the title feat: add deprecation warning for <code class="notranslate">auth-type` feat: add deprecation warning for auth-type May 16, 2022
@darcyclarke darcyclarke changed the title feat: add deprecation warning for auth-type feat(config): add deprecation warning for auth-type May 16, 2022
@darcyclarke darcyclarke changed the title feat(config): add deprecation warning for auth-type feat(config): remove deprecation warning for auth-type Jun 24, 2022
@wraithgar
Copy link
Member

we log deprecation on the auth values now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants