From d0163e7a4cc4c8f46a6c741630f43b7c2fc2f4c8 Mon Sep 17 00:00:00 2001 From: reggi Date: Wed, 11 Dec 2024 13:42:52 -0500 Subject: [PATCH] chore: lint and improve nested class --- lib/release/semver-versioning-strategy.js | 25 +++++++++++++++-------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/lib/release/semver-versioning-strategy.js b/lib/release/semver-versioning-strategy.js index b02f8322..6844deb3 100644 --- a/lib/release/semver-versioning-strategy.js +++ b/lib/release/semver-versioning-strategy.js @@ -11,7 +11,8 @@ const inc = (version, release, _preid) => { } const isFreshMajor = parsed.minor === 0 && parsed.patch === 0 const isFreshMinor = parsed.patch === 0 - const shouldPrerelease = (release === 'premajor' && isFreshMajor) || (release === 'preminor' && isFreshMinor) || release === 'prepatch' + const shouldPrerelease = + (release === 'premajor' && isFreshMajor) || (release === 'preminor' && isFreshMinor) || release === 'prepatch' if (shouldPrerelease) { return semver.inc(version, 'prerelease', preid) } @@ -31,19 +32,25 @@ const parseCommits = commits => { return release } +class SemverVersioningStrategyNested { + constructor(options, version, commits) { + this.options = options + this.commits = commits + this.version = version + } + + bump() { + return new SemverVersioningStrategy(this.options).bump(this.version, this.commits) + } +} + class SemverVersioningStrategy { constructor(options) { this.options = options } - determineReleaseType(_version, _commits) { - const options = this.options - class Shell { - bump() { - return new SemverVersioningStrategy(options).bump(_version, _commits) - } - } - return new Shell() + determineReleaseType(version, commits) { + return new SemverVersioningStrategyNested(this.options, version, commits) } bump(currentVersion, commits) {