From 7b248e88d3f3f6cca0da8c6758e4979f4e422f3e Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Thu, 17 Mar 2022 00:46:36 -0700 Subject: [PATCH] fix: use commitlint config via rc file only --- .github/workflows/pull-request.yml | 9 +++------ lib/content/pull-request.yml | 9 +++------ .../test/apply/full-content.js.test.cjs | 18 ++++++------------ 3 files changed, 12 insertions(+), 24 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index d434a7ff..93a5c3c9 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -29,13 +29,10 @@ jobs: run: npm i --prefer-online --no-fund --no-audit -g npm@latest - run: npm -v - name: Install deps - run: | - npm i -D @commitlint/cli @commitlint/config-conventional + run: npm i -D @commitlint/cli @commitlint/config-conventional - name: Check commits OR PR title env: PR_TITLE: ${{ github.event.pull_request.title }} run: | - npx commitlint -x @commitlint/config-conventional -V \ - --from origin/main --to ${{ github.event.pull_request.head.sha }} \ - || echo $PR_TITLE | \ - npx commitlint -x @commitlint/config-conventional -V + npx --offline commitlint -V --from origin/main --to ${{ github.event.pull_request.head.sha }} \ + || echo $PR_TITLE | npx --offline commitlint -V diff --git a/lib/content/pull-request.yml b/lib/content/pull-request.yml index 4566128f..04e48f0d 100644 --- a/lib/content/pull-request.yml +++ b/lib/content/pull-request.yml @@ -16,13 +16,10 @@ jobs: {{> setupGit with=(obj fetch-depth=0)}} {{> setupNode}} - name: Install deps - run: | - npm i -D @commitlint/cli @commitlint/config-conventional + run: npm i -D @commitlint/cli @commitlint/config-conventional - name: Check commits OR PR title env: PR_TITLE: $\{{ github.event.pull_request.title }} run: | - npx commitlint -x @commitlint/config-conventional -V \ - --from origin/main --to $\{{ github.event.pull_request.head.sha }} \ - || echo $PR_TITLE | \ - npx commitlint -x @commitlint/config-conventional -V + npx --offline commitlint -V --from origin/main --to $\{{ github.event.pull_request.head.sha }} \ + || echo $PR_TITLE | npx --offline commitlint -V diff --git a/tap-snapshots/test/apply/full-content.js.test.cjs b/tap-snapshots/test/apply/full-content.js.test.cjs index e47c63cf..369b6917 100644 --- a/tap-snapshots/test/apply/full-content.js.test.cjs +++ b/tap-snapshots/test/apply/full-content.js.test.cjs @@ -369,16 +369,13 @@ jobs: run: npm i --prefer-online --no-fund --no-audit -g npm@latest - run: npm -v - name: Install deps - run: | - npm i -D @commitlint/cli @commitlint/config-conventional + run: npm i -D @commitlint/cli @commitlint/config-conventional - name: Check commits OR PR title env: PR_TITLE: \${{ github.event.pull_request.title }} run: | - npx commitlint -x @commitlint/config-conventional -V / - --from origin/main --to \${{ github.event.pull_request.head.sha }} / - || echo $PR_TITLE | / - npx commitlint -x @commitlint/config-conventional -V + npx --offline commitlint -V --from origin/main --to \${{ github.event.pull_request.head.sha }} / + || echo $PR_TITLE | npx --offline commitlint -V .github/workflows/release-please.yml ======================================== @@ -1034,16 +1031,13 @@ jobs: run: npm i --prefer-online --no-fund --no-audit -g npm@latest - run: npm -v - name: Install deps - run: | - npm i -D @commitlint/cli @commitlint/config-conventional + run: npm i -D @commitlint/cli @commitlint/config-conventional - name: Check commits OR PR title env: PR_TITLE: \${{ github.event.pull_request.title }} run: | - npx commitlint -x @commitlint/config-conventional -V / - --from origin/main --to \${{ github.event.pull_request.head.sha }} / - || echo $PR_TITLE | / - npx commitlint -x @commitlint/config-conventional -V + npx --offline commitlint -V --from origin/main --to \${{ github.event.pull_request.head.sha }} / + || echo $PR_TITLE | npx --offline commitlint -V .github/workflows/release-please-bbb.yml ========================================