Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency definitions cause a non-functioning version combination #351

Closed
lekksi opened this issue Mar 23, 2023 · 4 comments · Fixed by #354
Closed

Dependency definitions cause a non-functioning version combination #351

lekksi opened this issue Mar 23, 2023 · 4 comments · Fixed by #354

Comments

@lekksi
Copy link

lekksi commented Mar 23, 2023

Description

Dependency definitions cause a non-functioning strawberry libraries version combination

Poetry resolves to:
strawberry-graphql = 0.163.2
strawberry-graphql-django = 0.9.2
strawberry-django-auth = 0.374.0
strawberry-django-plus = 1.35.2

These versions of strawberry-graphql and strawberry-django-plus seem to be incompatible (an import got broken due to the strawberry release 0.160.0. Release notes for 0.160.0 state that a deprecation warning should be shown but I'm getting an exception).

The issue is fixed in the newer strawberry-django-plus versions (tested with 2.0.6) but the current 0.374.0 release of strawberry-django-auth requires strawberry-django-plus = ">=1.25.2,<2.0.0".

Proposed fix

A release with the most recent changes in this repo would fix the issue. More specifically this commit.

I tested that everything works without a problem when installing this package directly from the main branch.

@lekksi
Copy link
Author

lekksi commented Mar 25, 2023

Hey, thanks for the quick response @nrbnlulu ! Unfortunately it looks like the release failed to auth error.

@nrbnlulu nrbnlulu reopened this Mar 25, 2023
@nrbnlulu
Copy link
Owner

Oh thanks, didn't noticed..

@nrbnlulu nrbnlulu reopened this Mar 26, 2023
@nrbnlulu
Copy link
Owner

should be fixed in 0.374.2 can you confirm?

@lekksi
Copy link
Author

lekksi commented Mar 26, 2023

@nrbnlulu yes, works with 0.374.2! Thanks!

@lekksi lekksi closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants