Skip to content

Commit

Permalink
fix(js): workspace lib devDependencies should not be added to package…
Browse files Browse the repository at this point in the history
….json (#17802)

(cherry picked from commit 9ba98f4)
  • Loading branch information
ajwootto authored and FrozenPandaz committed Sep 7, 2023
1 parent 22dadbc commit 14a4ef4
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/js/src/utils/package-json/update-package-json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,13 @@ function addMissingDependencies(
packageJson[propType][packageName] = version;
} else {
const packageName = entry.name;
if (!!workspacePackageJson.devDependencies?.[packageName]) {
return;
}

if (
!packageJson.dependencies?.[packageName] &&
!packageJson.devDependencies?.[packageName] &&
!packageJson.peerDependencies?.[packageName]
) {
const outputs = getOutputsForTargetAndConfiguration(
Expand Down

0 comments on commit 14a4ef4

Please sign in to comment.