-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib import breaks with @nrwl/web:rollup
with v14.1.8 and higher
#10539
Comments
Happens to me as well in a publishable react library after migrating from version 14.1.7 to version 14.1.8 and higher. All applications which consume this library start to throw these types of errors:
|
Hey @barchewbacca "build": {
"executor": "@nrwl/web:rollup",
"outputs": ["{options.outputPath}"],
"options": {
"outputPath": "libs/ui-components/dist",
"tsConfig": "libs/ui-components/tsconfig.lib.json",
"project": "libs/ui-components/package.json",
"entryFile": "libs/ui-components/src/index.ts",
"external": ["react/jsx-runtime"],
"rollupConfig": "@nrwl/react/plugins/bundle-rollup",
"compiler": "babel",
"assets": [
{
"glob": "libs/ui-components/README.md",
"input": ".",
"output": "."
}
],
"skipTypeField": true, // no longer generates "type": "module" on the lib dist/**/package.json
"format": ["cjs"]
}
}, Cheers! |
We have the same problem, which makes it impossible to upgrade to anything beyond We tried the
|
This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
After upgrading from
@nrwl/web
v14.1.7 to v14.1.8 or higher, a lib package cannot be resolved correctly anymore to e.g.@myorg/ui-components
. Changing the import to@myorg/ui-components/dist
works though.This PR is probably related to the issue: #10349
Expected Behavior
Build should pass just fine with
@myorg/ui-components
import like it did in 14.1.7Steps to Reproduce
This issue may not be prioritized if details are not provided to help us reproduce the issue.
Failure Logs
The error above occurs when running a remix application with the following nx executor beforehand:
Environment
The text was updated successfully, but these errors were encountered: