feat(misc): conditionally allow starter template inclusion #14268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…itionally-allow-starter-template
…itionally-allow-starter-template
|
Hi @Coly010 , @FrozenPandaz , I recreated this PR to master, hope all is good with it now. |
|
Hi @DirkoOdendaal , thanks for your PR. Can you change it to |
|
Hi @jaysoo , |
…itionally-allow-starter-template
…itionally-allow-starter-template
Coly010
force-pushed
the
feature/conditionally-allow-starter-template
branch
from
f00be79 to
4fb1429
Compare
Coly010
approved these changes
Jan 27, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When generating a new angular applications it always adds a NX welcome component to the application.
For us this is something we don't want, so we always delete the nx welcome component once it's created.
Expected Behavior
That the application generator has a flag to determine if a nx welcome component should be created or not.
This will speed up the generator itself if no component needs to be created or added.