feat(vite): allow passing multiple test files to vite:test #17496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eac6885. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
.../vite/src/migrations/update-16-4-0-update-test-file-config/update-16-4-0-test-file-config.ts
Outdated
Show resolved
Hide resolved
.../src/migrations/update-16-4-0-update-test-file-config/update-16-4-0-test-file-config.spec.ts
Outdated
Show resolved
Hide resolved
.../vite/src/migrations/update-16-4-0-update-test-file-config/update-16-4-0-test-file-config.ts
Outdated
Show resolved
Hide resolved
jwalton9
force-pushed
the
jw/multiple-test-files
branch
from
2729026
to
1beb63e
Compare
jwalton9
force-pushed
the
jw/multiple-test-files
branch
from
1beb63e
to
a877e37
Compare
barbados-clemens
approved these changes
Jun 20, 2023
packages/vite/migrations.json
Outdated
| "version": "16.4.0-beta.10", | ||
| "description": "Changes the testFile config in the vite:test exectutor from a string to an array of strings", | ||
| "cli": "nx", | ||
| "implementation": "./src/migrations/update-16-4-0-test-file-config/update-16-4-0-test-file-config" |
barbados-clemens
force-pushed
the
jw/multiple-test-files
branch
from
a877e37
to
eac6885
Compare
|
updated the tests to handle the option rename and updated the target for the migration |
ndcunningham
requested changes
Jun 26, 2023
ndcunningham
approved these changes
Jun 26, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
You can only pass one testfile to run to
vite:testExpected Behavior
Able to pass multiple test files to run to
vite:testthis is useful for CI for example when using test splitting