feat(core): set rust watcher as default #17728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 72e51bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Cammisuli
force-pushed
the
set_rust_watcher_as_default
branch
from
374a4af
to
49969db
Compare
Update the EventType enumeration in the watch/types.rs file to include a new value for "create". This change addresses a missing case in the event handling and enables better tracking of file creation events. Additionally, update associated tests to reflect this change.
Cammisuli
force-pushed
the
set_rust_watcher_as_default
branch
from
2f43d5d
to
514bf0a
Compare
FrozenPandaz
approved these changes
Jun 27, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
the rust watcher is optional and is hidden behind a
useNativeWatcherflag.Expected Behavior
The parcel watcher is now optional, and the rust one is enabled by default. If problems come up with the rust watcher, we have a fallback option to re-enable the parcel watcher by setting
useParcelWatcherto true in nx.json >taskRunnerOptions.default.options.useParcelWatcher