Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): update workspace libs setup in weback config #17795

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 26, 2023

Using the transpilePackages option from Next.js 13.1 is safer than updating the module rules ourselves, which can lead to future integration issues.

Note: This is tested for Next.js 12.2.6 as well (tested using https://github.com/jaysoo/nx-next-server-actions on different Next.js versions)

Current Behavior

Using use server directive and server actions lead to compile errors.

Expected Behavior

Using server actions should work.

Related Issue(s)

Fixes #16956

@jaysoo jaysoo requested a review from a team as a code owner June 26, 2023 15:35
@jaysoo jaysoo requested a review from ndcunningham June 26, 2023 15:35
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:47pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 258e0c3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Using the `transpilePackages` option from Next.js 13.1 is safer than
updating the module rules ourselves, which can lead to future
integration issues.

Note: This is tested for Next.js 12.2.6 as well
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants