fix(core): fix globbing in rust #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
approved these changes
Jun 26, 2023
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ac8e6fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
FrozenPandaz
added a commit
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 38101fd)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The globbing in rust did not handle
packages/*/package.jsonthe same way thatfast-globhandled it.Nested
node_moduleswere not ignored as they were before.Expected Behavior
The globbing in rust handles
packages/*/package.jsonand other globs with literal separators the same way.Nested
node_modulesare ignored as they were before.Related Issue(s)
Fixes #17797
Fixes #17774