Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): skip docs for private package #17843

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 6:31pm

@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ffdda2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from da5af18 to ea1a109 Compare June 29, 2023 05:03
@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from ea1a109 to 515c3d8 Compare June 29, 2023 13:50
@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from 515c3d8 to 8a60082 Compare June 29, 2023 14:22
@xiongemi xiongemi changed the title Fix/skip docs for private repo fix(nx-dev): skip docs for private package Jun 29, 2023
@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from 8a60082 to b7bc0cf Compare June 29, 2023 14:31
@xiongemi xiongemi marked this pull request as ready for review June 29, 2023 14:37
@xiongemi xiongemi requested a review from a team as a code owner June 29, 2023 14:37
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from ee938d8 to 12606d3 Compare June 30, 2023 17:19
@xiongemi xiongemi enabled auto-merge (squash) June 30, 2023 18:03
@xiongemi xiongemi force-pushed the fix/skip-docs-for-private-repo branch from 12606d3 to ffdda2c Compare June 30, 2023 18:28
@xiongemi xiongemi merged commit 0608318 into nrwl:master Jun 30, 2023
3 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
@xiongemi xiongemi deleted the fix/skip-docs-for-private-repo branch April 24, 2024 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants