fix(js): normalize tsconfig paths used as correlation keys in batch implementation #17888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bbfc927. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndcunningham
approved these changes
Jun 30, 2023
This was referenced Jul 1, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running a build with
@nx/js:tscbatch execution fails on Windows. It happens due to TS reporting the tsconfig paths in POSIX while we use an OS-specific path for those same files as the correlation key of our config objects.Failing run in Windows nightly: https://github.com/nrwl/nx/actions/runs/5417890221/jobs/9849458168#step:11:122
Expected Behavior
Running a build with
@nx/js:tscbatch execution should work on Windows.Successful run of this fix in Windows: https://github.com/leosvelperez/nx/actions/runs/5423423474/jobs/9861396587#step:11:122
Related Issue(s)
Fixes #