Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add test-setup.ts to ignored prod inputs #17918

Merged

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 3, 2023

Current Behavior

All dependencies of test-setup are now taking into account when collecting dependencies for createPackageJson

Expected Behavior

The test-setup.ts should be treated as other testing/linting helpers and ignored for production input.

Related Issue(s)

Related to #17905 (partial fix)

@meeroslav meeroslav requested a review from a team as a code owner July 3, 2023 10:11
@meeroslav meeroslav self-assigned this Jul 3, 2023
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 10:14am

@meeroslav meeroslav added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jul 3, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6f78c35. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz merged commit 8f0ec5c into nrwl:master Jul 4, 2023
4 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants