Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Respect CLI output path when provided #17947

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jul 4, 2023

When we pass --outputPath for building Next.js apps all the build artifacts should be inside that directory.

For example

nx build acme --outputPath='dist/sub'

Should have the following

dist
└── sub
    ├── next.config.js
    ├── package.json
    └── public
    └── .next
        └── ...
etc...

closes: #17881

@ndcunningham ndcunningham requested a review from a team as a code owner July 4, 2023 14:45
@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 2:48pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9c9041d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndcunningham ndcunningham self-assigned this Jul 4, 2023
@ndcunningham ndcunningham merged commit 50ee990 into nrwl:master Jul 4, 2023
3 checks passed
@ndcunningham ndcunningham deleted the fix/nextjs-output-path-cli branch July 4, 2023 19:58
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.next dir still in old outputPath when overriding using --outputPath cli flag on next.js build
2 participants