Support for @typescript-eslint/parser@v6

[lucavb]

• I'd be willing to implement this feature (contributing guide)

Description

Currently the eslint-package contains this line which prevents us from migrating to typescript-eslint@^6. I guess this might make it a breaking change for nx as well so this will only be included in version 17?

I also tried to find another issue targeting tihs but I was unable to find one.

Motivation

Well, pretty much the next major version with improvements being done by them.

Suggested Implementation

Updating the referenced line in the package.json and creating a migration.

Alternate Implementations

[k3nsei]

Just add this to your package.json

"overrides": {
  "@nx/eslint-plugin": {
    "@typescript-eslint/eslint-plugin": "^6.4.0",
    "@typescript-eslint/parser": "^6.4.0",
    "eslint-config-prettier": "^9.0.0"
  }
}

[meeroslav]

It's already on our roadmap.

@k3nsei, it's not that simple, as it requires some code migrations.

[k3nsei]

I know that works for me and allowed me to have all packages to their latest versions. I don't saying that this should be solution for NX. It is just quick issue solver for @lucavb

[meeroslav]

Sure, thank you @k3nsei

[JamesHenry]

The main thing we will need to do on the Nx side is update the module resolution configuration for TS: typescript-eslint/typescript-eslint#7284

This is a more significant change than just bumping packages, and we will need to make sure we think through the ramifications for all Nx users

[meeroslav]

As @JamesHenry mentioned, the biggest obstacle is the request to switch from node (version support for old node v10) to node16/next (which supports newer v16 onwards).

Although this change is sensible, it causes a chain reaction of changes requested across the entire repo. We will discuss this with the team next to see how to ensure the least amount of impact on other areas.

[eddiemonge]

Any progress on this? I know people still want to support Node versions older than 18, but 16 was end of life'd a month ago. Node 10 was EOL 3 and a half years ago. If people want to stay on dead Node versions, then they can lock their deps to versions that support that.

[meeroslav]

It's not a matter of node version. Our codebase dropped support for pre Node 16 versions some time ago. It's rather the changes this brings.

Switching to nodenext means all CommonJS packages will cease to work like before and their import will have to be modified to compensate for this.

We will likely do this once v17 is out, due to the scope of the changes needed (check draft PR here #19368)

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.