Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add @angular/pwa to migrations #18731 #18736

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 21, 2023

Current Behavior

We have missed migrating the @angular/pwa package when migrating angular packages

Expected Behavior

We include the @angular/pwa package when migrating angular packages

Related Issue(s)

Fixes #18731

@Coly010 Coly010 requested a review from a team as a code owner August 21, 2023 09:43
@Coly010 Coly010 self-assigned this Aug 21, 2023
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 11:15am

packages/angular/migrations.json Outdated Show resolved Hide resolved
@Coly010 Coly010 merged commit 791171e into master Aug 22, 2023
3 checks passed
@Coly010 Coly010 deleted the angular/fix-pwa-migration branch August 22, 2023 09:24
FrozenPandaz pushed a commit that referenced this pull request Aug 23, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade @angular/pwa in migrate command
3 participants