fix(linter): do not break migration if eslint file is missing #18762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
commented
Aug 22, 2023
| @@ -38,9 +40,8 @@ export function migrateConfigToMonorepoStyle( | |||
| export function findLintTarget( | |||
| project: ProjectConfiguration | |||
| ): TargetConfiguration { | |||
| return Object.entries(project.targets ?? {}).find( | |||
| ([name, target]) => | |||
| name === 'lint' || | |||
There was a problem hiding this comment.
This is very prone to misuse and does not guarantee that the lint uses the ESLint config.
meeroslav
commented
Aug 22, 2023
| ); | ||
| const eslintFile = | ||
| lintTarget.options.eslintConfig || findEslintFile(tree, project.root); | ||
| if (!eslintFile) { |
There was a problem hiding this comment.
Of config does not exist, we should silently continue migrating other projects
JamesHenry
approved these changes
Aug 29, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #18544
Fixes #18377