Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): normalize remote name and directory correctly when using new project root format #18770

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 22, 2023
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 2:27pm

@leosvelperez leosvelperez force-pushed the react/fix-remote-generation-as-provided branch from 11d4efa to 4160563 Compare August 22, 2023 13:45
@leosvelperez leosvelperez marked this pull request as ready for review August 22, 2023 13:45
@leosvelperez leosvelperez requested a review from a team as a code owner August 22, 2023 13:45
@leosvelperez leosvelperez merged commit d1da057 into nrwl:master Aug 22, 2023
3 checks passed
@leosvelperez leosvelperez deleted the react/fix-remote-generation-as-provided branch August 22, 2023 15:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants