Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): style=none should not create file #18785 #18836

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 25, 2023

Current Behavior

When --style=none is passed, we are creating a component.none file containing styles.

Expected Behavior

We should not create this file when --style=none

Related Issue(s)

Fixes #18785

@Coly010 Coly010 requested a review from a team as a code owner August 25, 2023 10:10
@Coly010 Coly010 requested a review from jaysoo August 25, 2023 10:10
@Coly010 Coly010 self-assigned this Aug 25, 2023
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Aug 25, 2023 10:13am

@Coly010 Coly010 merged commit 577f820 into nrwl:master Aug 25, 2023
3 checks passed
@Coly010 Coly010 deleted the angular/fix-style-generation branch August 25, 2023 10:55
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running nx generate @nx/angular:component --style=none produces test.component.none file
2 participants