feat(linter): migrate projects using dep-check lint rule to ignore build config files #18882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
feat/linter-migrate-ignore
branch
from
77b0688
to
f98deb7
Compare
jaysoo
force-pushed
the
feat/linter-migrate-ignore
branch
from
f98deb7
to
278ba8b
Compare
meeroslav
reviewed
Aug 29, 2023
| (o) => !!o.rules?.['@nx/dependency-checks'], | ||
| (o) => { | ||
| const value = o.rules['@nx/dependency-checks']; | ||
| let ruleSeverity: 0 | 1 | 2 | 'error' | 'warn' | 'off'; |
There was a problem hiding this comment.
This is no longer correct. The current type doesn't support numbers
There was a problem hiding this comment.
It was giving me type errors if I don't include them. I can cast as any as well.
meeroslav
approved these changes
Aug 30, 2023
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration to add
ignoredFilesoption to@nx/dependency-checksfor projects using vite, esbuild, and rollup. We need to ignore config files such asvite.config.tsso the packages imported in them are not marked as production dependencies by the lint rule.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #