fix(linter): ensure config manipulations are run only if config is supported #19035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
approved these changes
Sep 6, 2023
meeroslav
force-pushed
the
enforce-lint-config-support-check
branch
from
2efcea3
to
4c99252
Compare
meeroslav
commented
Sep 7, 2023
| @@ -8,6 +8,7 @@ describe('update-16-8-0-add-ignored-files migration', () => { | |||
|
|
|||
| beforeEach(() => { | |||
| tree = createTreeWithEmptyWorkspace(); | |||
| tree.write('.eslintrc.json', '{}'); | |||
There was a problem hiding this comment.
This is necessary for isEslintConfigSupported to work. Normally, the root eslintrc would be there
JamesHenry
approved these changes
Sep 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We do ad hoc checks for existence of eslint config when we detect error
Expected Behavior
We should use central
isEslintConfigSupportedfunction, which will help us to potentially add support for more config types and we would need to change just one function.E.g. migrating from yaml and classic js is fairly trivial after support of json.
Related Issue(s)
Related to #19026 and #19020