Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-nx-workspace can create a workspace with missing jsdom dependency #19853

Closed
1 of 4 tasks
igilham opened this issue Oct 25, 2023 · 2 comments · Fixed by #19859
Closed
1 of 4 tasks

create-nx-workspace can create a workspace with missing jsdom dependency #19853

igilham opened this issue Oct 25, 2023 · 2 comments · Fixed by #19859

Comments

@igilham
Copy link

igilham commented Oct 25, 2023

Current Behavior

Creating a new standalone workspace sets up Vite with the jsdom environment but does not install jsdom, so it fails to run the sample test.

Expected Behavior

Either don't use jsdom in the environment environment (the user did not ask for it) or install it so the out-of-box experience is not broken.

GitHub Repo

No response

Steps to Reproduce

npm i -g nx
npx create-nx-workspace workspace
> None
> Standalone
> Typescript? Yes or No
> Enable distributed caching? No

cd example
nx test example
MISSING DEP  Can not find dependency 'jsdom'

Nx Report

NX   Report complete - copy this into the issue template

   Node   : 18.12.1
   OS     : darwin-arm64
   npm    : 9.6.1

   nx (global)        : 17.0.1
   nx                 : 17.0.1
   @nx/js             : 17.0.1
   @nx/linter         : 17.0.1
   @nx/eslint         : 17.0.1
   @nx/workspace      : 17.0.1
   @nx/devkit         : 17.0.1
   @nx/eslint-plugin  : 17.0.1
   @nrwl/tao          : 17.0.1
   @nx/vite           : 17.0.1
   typescript         : 5.1.6

Failure Logs

MISSING DEP  Can not find dependency 'jsdom'

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Shared on discord.

@ndcunningham ndcunningham self-assigned this Oct 25, 2023
@ndcunningham
Copy link
Contributor

ndcunningham commented Oct 25, 2023

Hi, thanks for reporting this is an error on our end. It should be set to 'node' you can change it as a workaround for now until the fix has been pushed, which would probably be in a upcoming release.

ndcunningham added a commit to ndcunningham/nx that referenced this issue Oct 25, 2023
ndcunningham added a commit to ndcunningham/nx that referenced this issue Oct 25, 2023
ndcunningham added a commit to ndcunningham/nx that referenced this issue Oct 26, 2023
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants