Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): generate should handle multiselect shorthand #19790

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Oct 23, 2023

Current Behavior

Some angular devkit schematics use a shorthand for multiselects inside of schema.json that looks something like this:

"propertyName": {
      "type": "array",
      "description": "Specifies which type of guard to create.",
      "items": {
        "enum": ["CanActivate", "CanActivateChild", "CanDeactivate", "CanMatch"],
        "type": "string"
      },
      "default": ["CanActivate"],
      "x-prompt": "Which type of guard would you like to create?"
    }

Currently, this is parsed as a string input

Expected Behavior

This renders a multiselect.

Related Issue(s)

Fixes #19142

@AgentEnder AgentEnder requested a review from a team as a code owner October 23, 2023 14:08
@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 1:41pm

@AgentEnder AgentEnder force-pushed the fix/params-multiselect-shorthand branch 2 times, most recently from 10e98b8 to 6a68dc1 Compare October 23, 2023 21:29
@AgentEnder AgentEnder force-pushed the fix/params-multiselect-shorthand branch from 6a68dc1 to 013621a Compare October 26, 2023 13:40
@FrozenPandaz FrozenPandaz merged commit 7db366b into nrwl:master Oct 31, 2023
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Nov 2, 2023
Copy link

github-actions bot commented Nov 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create gard using nx
2 participants