Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE-344 HA Data cluster #29

Merged
merged 1 commit into from
Oct 25, 2019
Merged

RE-344 HA Data cluster #29

merged 1 commit into from
Oct 25, 2019

Conversation

saxmfone1
Copy link
Contributor

No description provided.

@saxmfone1 saxmfone1 changed the title Clustering RE-344 Clustering Oct 25, 2019
@saxmfone1 saxmfone1 changed the title RE-344 Clustering RE-344 HA Data cluster Oct 25, 2019
mburtless
mburtless suggested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@mburtless mburtless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the README. There's a couple of ways to implement input variable validation for cluster_size, but your call how badly we need that.

terraform/examples/multi-node-cluster/README.md Outdated Show resolved Hide resolved
terraform/modules/data/variables.tf Show resolved Hide resolved
@mburtless
Copy link
Contributor

🚀

@saxmfone1 saxmfone1 merged commit be13c1a into master Oct 25, 2019
@saxmfone1 saxmfone1 deleted the clustering branch October 25, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburtless mburtless mburtless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saxmfone1 @mburtless