Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove neo-go dependency #87

Closed
fyfyrchik opened this issue Dec 21, 2023 · 1 comment
Closed

Remove neo-go dependency #87

fyfyrchik opened this issue Dec 21, 2023 · 1 comment
Labels
enhancement Improving existing functionality

Comments

@fyfyrchik
Copy link

It is a circular dependency and sometimes lead to problems (I had some problems GOPROXY=direct after cleaning the cache)
We use only 2 packages from there:
neo-go/pkg/io: to serialize example messages. They are redefined in neo-go (protocol uses interfaces), so example messages can use any serialization scheme (json, gob, raw encoding/binary helpers, whatever).
neo-go/pkg/util: for util.Uint* numbers. For these generics could be used.

IMO example messages are still good, to use in tests or simulation.
Another option is embed this library to neo-go, but this is more costly.

@fyfyrchik fyfyrchik added the enhancement Improving existing functionality label Dec 21, 2023
@roman-khimov
Copy link
Member

Duplicates #2. I'll reopen it, but it was never a problem to me.

@roman-khimov roman-khimov closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants