Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use big numbers in RPC queries #2350

Closed
fyrchik opened this issue Feb 4, 2022 · 1 comment · Fixed by #2413
Closed

Allow to use big numbers in RPC queries #2350

fyrchik opened this issue Feb 4, 2022 · 1 comment · Fixed by #2413
Assignees
@fyrchik
Labels
rpc RPC server and client

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Feb 4, 2022 •
edited
Loading

There are 2 issues which prevent us from using big integers when working via RPC:

  1. Smartcontract Integer parameter expects int64 as a value. https://github.com/nspcc-dev/neo-go/blob/master/pkg/smartcontract/parameter.go#L67 .
  2. Request parameter is converted to int (not even int64) when building invocation script https://github.com/nspcc-dev/neo-go/blob/01d15ff473f9984023e9c1e04be107981acec80e/pkg/rpc/request/txBuilder.go#L65-66 .
@fyrchik fyrchik mentioned this issue Feb 4, 2022
Merged
@roman-khimov
Copy link
Member

The second one is rather trivial, but nspcc-dev/neofs-node#122 (comment)

@fyrchik fyrchik mentioned this issue Feb 7, 2022
Closed
@roman-khimov roman-khimov added the rpc RPC server and client label Feb 8, 2022
@fyrchik fyrchik mentioned this issue Feb 9, 2022
Merged
@fyrchik fyrchik mentioned this issue Mar 30, 2022
Merged
@cthulhu-rider cthulhu-rider mentioned this issue May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
rpc RPC server and client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

smartcontract: allow to use *big.Int numbers for integers nspcc-dev/neo-go
2 participants
@fyrchik @roman-khimov