Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve index files parsing for BlockFetcher service #3585

Open
AnnaShaleva opened this issue Sep 12, 2024 · 0 comments
Open

Improve index files parsing for BlockFetcher service #3585

AnnaShaleva opened this issue Sep 12, 2024 · 0 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Problem is described in #3515 (comment). If request timeout configuration is small, then OID-reading routine may fail due to request context timeout. I'd not consider this behaviour as a bug, but at the same time it's something that can be improved.

Describe the solution you'd like

The only thing that came to my mind is to make the receiver channel's buffer size be multiple of index file size in order to avoid possible awaiting on "send to OID channel" operation in the middle of index file parsing.

Describe alternatives you've considered

Other alternatives are welcomed.

@AnnaShaleva AnnaShaleva added I3 Minimal impact U3 Regular enhancement Improving existing functionality S3 Minimally significant labels Sep 12, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.4 milestone Sep 12, 2024
@roman-khimov roman-khimov modified the milestones: v0.106.4, v0.107.0 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants