Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podAnnotations - did not find expected key #10

Closed
alanorther opened this issue Jan 5, 2023 · 1 comment · Fixed by #14
Closed

podAnnotations - did not find expected key #10

alanorther opened this issue Jan 5, 2023 · 1 comment · Fixed by #14

Comments

@alanorther
Copy link

Issue:

Adding podAnnotations value to nsqlookupd, nsqadmin, or nsqd in the values file gives the following error or similar:
helm upgrade --install -f nsq-values.yaml nsq nsqio/nsq
Error: UPGRADE FAILED: YAML parse error on nsq/templates/nsqadmin-deployment.yaml: error converting YAML to JSON: yaml: line 19: did not find expected key

Example Values File Input:

  podAnnotations:
    Test_Annotations: "testing"

Fix to template files:

    metadata:
      {{- with .Values.nsqlookupd.podAnnotations }}
+     annotations:
        {{- toYaml . | nindent 8 }}
      {{- end }}

Files that require update:

templates/nsqadmin-deployment.yaml
templates/nsqd-statefulset.yaml
templates/nsqlookupd-statefulset.yaml

@ploxiln
Copy link
Member

ploxiln commented Jan 13, 2023

Hmm, it's been that way from the first commit in this repo. Maybe no-one ever used podAnnotations. Though maybe you could theoretically do something like:

podAnnotations:
  annotations:
    myrealm: blue

Anyway, would you like to open a Pull Request with your suggested fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants